Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are using deprecated settings #3481

Open
nicobleiler opened this issue Dec 18, 2024 · 1 comment
Open

Docs are using deprecated settings #3481

nicobleiler opened this issue Dec 18, 2024 · 1 comment

Comments

@nicobleiler
Copy link

Environment

self-hosted (https://develop.sentry.dev/self-hosted/)

Steps to Reproduce

Follow the docs https://develop.sentry.dev/self-hosted/sso/#github-auth

In sentry/sentry.conf.py

GITHUB_APP_ID="<App ID>"
GITHUB_API_SECRET="<Client secret>"
GITHUB_REQUIRE_VERIFIED_EMAIL = True  # Optional but recommended

# Only if you are using GitHub Enterprise
#GITHUB_BASE_DOMAIN = "git.example.com"
#GITHUB_API_DOMAIN = "api.git.example.com"

Expected Result

No deprecation warnings

Actual Result

Following the docs results in Deprecation warning

/usr/src/sentry/src/sentry/runner/initializer.py:200: DeprecatedSettingWarning: The GITHUB_APP_ID setting is deprecated. Please use SENTRY_OPTIONS['github-login.client-id'] instead.
warnings.warn(DeprecatedSettingWarning(options_mapper[k], "SENTRY_OPTIONS['%s']" % k))
/usr/src/sentry/src/sentry/runner/initializer.py:200: DeprecatedSettingWarning: The GITHUB_API_SECRET setting is deprecated. Please use SENTRY_OPTIONS['github-login.client-secret'] instead.
warnings.warn(DeprecatedSettingWarning(options_mapper[k], "SENTRY_OPTIONS['%s']" % k))
/usr/src/sentry/src/sentry/runner/initializer.py:200: DeprecatedSettingWarning: The GITHUB_REQUIRE_VERIFIED_EMAIL setting is deprecated. Please use SENTRY_OPTIONS['github-login.require-verified-email'] instead.
warnings.warn(DeprecatedSettingWarning(options_mapper[k], "SENTRY_OPTIONS['%s']" % k))

Product Area

Other

Link

No response

DSN

No response

Version

24.11.0

@getsantry
Copy link

getsantry bot commented Dec 18, 2024

Assigning to @getsentry/support for routing ⏲️

@InterstellarStella InterstellarStella transferred this issue from getsentry/sentry Dec 19, 2024
@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants