feat(server): Send pre-aggregated metrics in batches #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Mar 26, 2021
| tags: metric.tags, | ||
| })?; | ||
| } | ||
| for bucket in Bucket::parse_all(&payload).unwrap_or_default() { |
There was a problem hiding this comment.
@jan-auer It feels wrong that we have to deserialize here. Is there any way we can bypass the serialization step?
There was a problem hiding this comment.
Agreed, and we have the same issue with sessions. Right now, there's no straight forward way to avoid it, since we have to transform the payload and insert new attributes.
We could move this step into the EventManager, bypassing the Envelope, but I'm not clear yet what a good solution would look like. For now, I'd propose to keep it this way and solve both metrics and sessions together.
jan-auer
changed the title
jan-auer
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the metrics aggregator from #958 to send batches of pre-aggregated
buckets to the upstream instead of forwarding individual metric values.
If sending fails for any reason, the metrics are merged back into the
aggregator, which will retry flushing after the next interval.
Metric envelopes are not queued like regular envelopes. Instead, they go
straight to the
EventProcessorworker pool, where they are parsed,normalized and sent to the project's aggregator. This ensures that
metric requests do not create long running futures that would slow down
the system. For mixed envelopes, metric items are split off and handled
separately.
Metrics aggregators are spawned on the projects thread, which runs the
project cache and manages all project state access. In the future,
metrics aggregation will have to be moved to a separate resource to
ensure that project state requests remain instant.