ref(common): Make the DSN public key Copy #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Oct 5, 2020
untitaker
reviewed
Oct 5, 2020
|
|
||
| /// Data scoping information. | ||
| /// | ||
| /// This structure holds information of all scopes required for attributing an item to quotas. | ||
| #[derive(Clone, Debug)] | ||
| #[derive(Clone, Copy, Debug)] |
There was a problem hiding this comment.
since this is now Copy theoretically you can put it into ItemScoping without a lifetime
There was a problem hiding this comment.
Actually, I'll leave it like this. The ItemScoping type is quite large, and since one should only temporarily hold an item scoping, it's probably fine to keep it with a reference.
untitaker
added a commit
that referenced
this pull request
Sep 6, 2021
We should be able to represent all DSNs with half the bytes. I validated that we don't have non-hex DSNs in prod, this returns 0: select count(*) from sentry_projectkey where encode(decode(public_key, 'hex'), 'hex') != public_key This should solve the concern voiced by Jan in #795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a type for DSN public keys that implements copy. Every public key is a 32-character hexadecimal string. Storage requirements could be halved by parsing the hexadecimal contents of the key, however this is currently not enforced anywhere in Sentry. For this reason, we're taking the conservative approach using 32 bytes.
The type is called
ProjectKeyto distinguish it from Relay's own public key.#skip-changelog