Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(server): Bring back upstream response transformer #794

Merged
merged 1 commit into from
Oct 5, 2020
Merged

ref(server): Bring back upstream response transformer #794

merged 1 commit into from
Oct 5, 2020

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Oct 5, 2020 •
edited
Loading

Brings back the ResponseTransformer trait for upstream::SendRequest, which was previously removed in #678, for two reasons:

  • It will allow to deduplicate the code that consumes response bodies when we don't need to parse them. This is currently done twice: Once for SendRequest and once for the manual CheckUpstreamConnection message.

  • It allows other actors to call SendRequest with a response body. We need this in ref(server): Cache projects by public key #778

#skip-changelog

@jan-auer jan-auer requested review from RaduW and a team October 5, 2020 11:18
@jan-auer jan-auer self-assigned this Oct 5, 2020
@jan-auer jan-auer merged commit 0415a69 into master Oct 5, 2020
@jan-auer jan-auer deleted the ref/upstream-response-transformer branch October 5, 2020 11:56
jan-auer added a commit that referenced this pull request Oct 5, 2020
@jan-auer
Merge branch 'master' into feat/redirect-dsn
75bd299 
* master:
  ref(common): Make the DSN public key Copy (#795)
  ref(server): Bring back upstream response transformer (#794)
  ref(server): Upstream request retries & re-authentication (#788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

@RaduW RaduW Awaiting requested review from RaduW

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @untitaker