ref: size-optimize the relay python library #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in my tests |
asottile-sentry
force-pushed
the
asottile-size-optimize-librelay
branch
from
51e95a0 to
cde1565
Compare
|
the downside is this makes the build take about 2x -- but I suspect that can be won back by switching the macos builders to the macos arm runners |
on linux this reduces the installed library size from 240MB to 14MB
asottile-sentry
force-pushed
the
asottile-size-optimize-librelay
branch
from
cde1565 to
9116167
Compare
|
hooray after switching over the macos builders it is no longer slower 🎉 |
jan-auer
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on linux this reduces the installed library size from 240MB to 14MB (might actually be smaller but I'm impatient -- that number was with
debug = truestill accidentally on)