feat(spans): Global config for AI model costs #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
May 10, 2024
| @@ -46,6 +46,9 @@ pub struct GlobalConfig { | |||
| /// applying. | |||
| #[serde(skip_serializing_if = "is_ok_and_empty")] | |||
| pub metric_extraction: ErrorBoundary<MetricExtractionGroups>, | |||
|
|
|||
| /// Configuration for AI span measurements. | |||
| pub ai_model_costs: ErrorBoundary<ai::ModelCosts>, | |||
There was a problem hiding this comment.
Will add a skip_serializing_if here.
Dav1dde
approved these changes
May 10, 2024
| #[serde(rename_all = "camelCase")] | ||
| pub struct ModelCost { | ||
| model_id: LazyGlob, | ||
| for_completion: bool, |
There was a problem hiding this comment.
Maybe this makes sense as an enum, but not familiar enough with AI terminology:
enum Usage {
Completion,
NotCompletionButTheDefaultUsecase,
// MaybeSomeFutureUsecase,
}@colin-sentry wdyt?
There was a problem hiding this comment.
the SDKs only send the static prompt_tokens, completion_tokens, and total_tokens, so it's probably fine to keep as a boolean
| @@ -46,6 +46,9 @@ pub struct GlobalConfig { | |||
| /// applying. | |||
| #[serde(skip_serializing_if = "is_ok_and_empty")] | |||
| pub metric_extraction: ErrorBoundary<MetricExtractionGroups>, | |||
|
|
|||
| /// Configuration for AI span measurements. | |||
| pub ai_model_costs: ErrorBoundary<ai::ModelCosts>, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3554.
#skip-changelog