Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(metrics): Change MetricHour data category to MetricSecond #3558

Merged
merged 2 commits into from
May 7, 2024
Merged

ref(metrics): Change MetricHour data category to MetricSecond #3558

merged 2 commits into from
May 7, 2024
+13 −13

Conversation

mbauer404
Copy link
Contributor

@mbauer404 mbauer404 commented May 6, 2024 •
edited
Loading

A new DataCategory for METRIC_HOUR was added in #3384 that revenue will use in future outcomes consumer that summarizes metric usage. It was determined that we will be storing usage based on second buckets instead of hour buckets, so we are updating the data category to reflect that.

The data category is not being used in sentry/getsentry yet.

Relevant tech specs:

https://www.notion.so/sentry/Metric-Hour-Pricing-2817cfeb664b47418bc82b397638b75c
https://www.notion.so/sentry/Billing-for-Metrics-552b2f6dcf9b4bb48ae7732afd14ddc3

@mbauer404 mbauer404 requested a review from a team as a code owner May 6, 2024 23:15
@mbauer404 mbauer404 requested a review from a team May 6, 2024 23:27
@Dav1dde Dav1dde changed the title Updating to DataCategory::MetricSecond ref(metrics): Change MetricHour data category to MetricSecond May 7, 2024
@Dav1dde
Copy link
Member

Dav1dde commented May 7, 2024

For the future, please follow the commit guidelines when naming the PR.

@mbauer404 mbauer404 merged commit 111f6c8 into master May 7, 2024
26 checks passed
@mbauer404 mbauer404 deleted the mbauer/update-to-data-category-metric-second branch May 7, 2024 17:43
jan-auer added a commit that referenced this pull request May 8, 2024
@jan-auer
Merge branch 'master' into ref/healthcheck-async
cceac14 
* master:
  ref(aws): Remove the aws extension (#3568)
  ref(metrics): Change MetricHour data category to MetricSecond (#3558)
  chore(self-hosted): Mark e2e test check as required (#3557)
  feat(spans): Extracts messaging.message.id for queue spans (#3556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashed dashed dashed approved these changes

@Dav1dde Dav1dde Dav1dde approved these changes

@vbro vbro vbro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbauer404 @Dav1dde @dashed @vbro