Adding DataCategory::MetricHour #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbro
reviewed
Apr 5, 2024
relay-cabi/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "relay-cabi" | |||
| version = "0.8.56" | |||
| version = "0.8.57" | |||
There was a problem hiding this comment.
The version change seems to be done automatically by a bot.
Otherwise LGTM. I'll let Ingest give the final approval.
There was a problem hiding this comment.
Ah ok, so then I'll revert this part?
There was a problem hiding this comment.
Correct, the release is done with a github action.
Dav1dde
reviewed
Apr 8, 2024
jjbayer
approved these changes
Apr 9, 2024
Co-authored-by: Joris Bayer <[email protected]>
mbauer404
added a commit
that referenced
this pull request
May 7, 2024
A new DataCategory for METRIC_HOUR was added in [#3384](#3384) that revenue will use in future outcomes consumer that summarizes metric usage. It was determined that we will be storing usage based on second buckets instead of hour buckets, so we are updating the data category to reflect that. The data category is not being used in sentry/getsentry yet. Relevant tech specs: https://www.notion.so/sentry/Metric-Hour-Pricing-2817cfeb664b47418bc82b397638b75c https://www.notion.so/sentry/Billing-for-Metrics-552b2f6dcf9b4bb48ae7732afd14ddc3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the DataCategory
METRIC_HOUR, a category that revenue will use in future outcomes consume that summarizes metric usage by hour buckets with the productMax Metric Tenancy X Max Metric CardinalityRelevant tech specs:
https://www.notion.so/sentry/Metric-Hour-Pricing-2817cfeb664b47418bc82b397638b75c
https://www.notion.so/sentry/Billing-for-Metrics-552b2f6dcf9b4bb48ae7732afd14ddc3
I think I got everything, let me know if something was missed!