feat(spans): Remove count_per_segment & count_per_op metric #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
reviewed
Apr 5, 2024
shruthilayaj
changed the title
phacops
approved these changes
Apr 5, 2024
Dav1dde
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
No references to this metric in the sentry backend.
They are referenced in strings.py but that should probably stay.
cc: @jjbayer jfyi
Indeed since this file is frozen and we do not want to modify it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't end up doing the work to use this and pivoted to other features.
We also collect the information we need with the the exclusive_time metric
now, so this can be removed.
No references to this metric in the sentry backend.