chore(csp): Filter out unsupported report types #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Mar 21, 2024
| @@ -72,6 +74,21 @@ impl SecurityReportParams { | |||
| } | |||
| } | |||
|
|
|||
| /// Check if the report type is supported. | |||
There was a problem hiding this comment.
Suggested change
| /// Check if the report type is supported. | |
| /// Checks if the report type is supported. |
| @@ -72,6 +74,21 @@ impl SecurityReportParams { | |||
| } | |||
| } | |||
|
|
|||
| /// Check if the report type is supported. | |||
| /// | |||
| /// Note: use only for the reports sent through the Reporting Api. | |||
There was a problem hiding this comment.
Suggested change
| /// Note: use only for the reports sent through the Reporting Api. | |
| /// Note: use only for the reports sent through the Reporting API. |
| Self::create_security_item(&query, Bytes::from(item.to_owned().to_string())); | ||
| envelope.add_item(report_item); | ||
| let data = Bytes::from(item.to_owned().to_string()); | ||
| if is_supported_type(&data) { |
There was a problem hiding this comment.
Instead of parsing the data here, couldn't we filter out the unsupported type in the envelope processor (after or during the parsing step)?
There was a problem hiding this comment.
I first thought to do it in processor, but then , I've got an idea to discard those items as earlier as possible and later we won't do extra work. But yeah, I will move this back to processor.
Dav1dde
reviewed
Mar 21, 2024
Dav1dde
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case if the default report group defined and used for CSP reports (with Reporting Api), browser also will use that group for sending
deprecationreports, which we do not support and should filter them out.followup for #3293 #3277
#skip-changelog