feat(globalconfig): Only report upstream errors after elapsed interval #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially during deployments, Relay sometimes faces some 503s or timeouts from upstream, and reports an error. Having a handful of such errors is noisy and doesn't help to identify when problems really exist. This change introduces an interval the global config service has to wait before reporting such errors, while consistently failing fetches. Note that the interval does not impact other type of errors, like failure to send requests to upstream (e.g. network is down) or global config missing from the response. These errors are consistent and should be reported as early as possible.
| @@ -164,6 +170,8 @@ impl GlobalConfigService { | |||
| internal_rx, | |||
| upstream, | |||
| fetch_handle: SleepHandle::idle(), | |||
| last_fetched: Instant::now(), | |||
| upstream_failure_interval: Duration::from_secs(35), | |||
There was a problem hiding this comment.
35 is arbitrary, but should have time for 3 requests (after 10s each).
There was a problem hiding this comment.
We may not need it for now, but I'll keep this in mind to address it in the future.
jjbayer
approved these changes
Oct 18, 2023
| @@ -164,6 +170,8 @@ impl GlobalConfigService { | |||
| internal_rx, | |||
| upstream, | |||
| fetch_handle: SleepHandle::idle(), | |||
| last_fetched: Instant::now(), | |||
| upstream_failure_interval: Duration::from_secs(35), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially during deployments, Relay sometimes faces some 503s or timeouts from upstream, and reports an error. Having a handful of such errors is noisy and doesn't help to identify when problems really exist.
This change introduces an interval the global config service has to wait before reporting such errors, while consistently failing fetches.
Note that the interval does not impact other types of errors, like failure to send requests to upstream (e.g. network is down) or global config missing from the response. These errors are consistent and should be reported as early as possible.
Resolves #2609.