fix(filter): Apply transaction name filter to transaction events #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
reviewed
Jul 6, 2023
| if event.ty.value() != Some(&EventType::Transaction) { | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Could we add the unit test at least to make sure this won't happen again?
There was a problem hiding this comment.
Will add test, will also fix the currently failing tests (that do not have the event type set)
RaduW
approved these changes
Jul 6, 2023
olksdr
approved these changes
Jul 6, 2023
|
Thank you! Much appreciate the fix as I encountered this in the wild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transaction name filter is used to drop health check and ping transaction
events. The original PR missed to check for the event type and also dropped
errors. This patch adds a check for the event type and lets all errors through.