feat(normalization): Mark scrubbed transactions as sanitized #1960
Conversation
All transactions that got their names scrubbed will be marked as sanitized, as long as the org feature flag is enabled.
There was a problem hiding this comment.
@iker-barriocanal did you check if affected orgs currently have any high-cardinality transactions that would destroy the UX with this change?
There was a problem hiding this comment.
I think it's fine, but we can also consider limiting the flag to Sentry orgs for now.
@iker-barriocanal My question was specifically whether or not the affected org(s) still had a lot of URL transactions with identifiers that we failed to parameterize. In the mean time I found the answer myself: the affected customer project only has a handful of high-volume but low-cardinality transactions labeled as url, so we can go ahead with the change.
|
@jjbayer I checked the projects for that org and |
* master: feat(normalization): Mark scrubbed transactions as sanitized (#1960) fix(pii): Scrub sensitive cookies (#1951) release: 23.3.1 feat(pii-scrubbing): PII scrub span.data by default (#1953) test(scrubbing): Add tests for PII scrubbing in breadcrumb.data (#1955) build(deps): bump sentry-sdk from 1.11.0 to 1.14.0 (#1959) ref(envelope_manager): Remove from_registry calls from the service (#1956) cd: add placeholder deployment pipeline (#1954) Assert array fields are capped to 100 items (#1910) fix(pii): Early return if no text left (#1957)
All transactions that got their names scrubbed will be marked as sanitized, as long as the org feature flag is enabled.
6961c5e includes a small refactor around the usage of feature flags. Although it may seem like it, this doesn't change the behavior of relay around the application of transaction rules, since the initial flag belonging to
scrub_identifierscontrols the generation of rules insentry, see.Ref: https://github.com/getsentry/team-ingest/issues/93
#skip-changelog