Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general): Add new debug image variants #188

Merged
merged 3 commits into from
Mar 20, 2019
Merged

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Mar 19, 2019

This adds new variants for debug images (elf, macho and pe). Since they are structurally equivalent, they all use the same type NativeDebugImage, which is also used by the now legacy symbolic variant. apple is now considered a legacy alias to macho.

Conversion apple -> macho:

Since the Apple type effectively describes MachO, the normalizer now automatically performs a conversion. Note that this discards the cpu_name and cpu_type values, but those are no longer required for symbolication. This is also performed during renormalization.

Renamed properties:

  • id -> debug_id (required)
  • name -> code_file (required)

New optional properties:

  • code_id
  • debug_file

@jan-auer jan-auer requested review from mitsuhiko and untitaker March 19, 2019 14:25
@codecov-io
Copy link

Codecov Report

Merging #188 into master will increase coverage by 0.33%.
The diff coverage is 89.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   64.81%   65.15%   +0.33%     
==========================================
  Files          83       84       +1     
  Lines        9042     9126      +84     
==========================================
+ Hits         5861     5946      +85     
+ Misses       3181     3180       -1
Impacted Files Coverage Δ
general/src/store/mod.rs 81.25% <75%> (+2.67%) ⬆️
general/src/protocol/debugmeta.rs 94.63% <89%> (+4.05%) ⬆️
general/src/store/legacy.rs 93.33% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10dc971...96bea13. Read the comment docs.

@jan-auer
Copy link
Member Author

This is a breaking change (due to the apple -> macho normalization), thus this will be released as 0.5.0.

@jan-auer jan-auer merged commit 77bf8ab into master Mar 20, 2019
@jan-auer jan-auer deleted the feat/debug-image-types branch March 20, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants