-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replays): Use user configured PII scrubbers #1731
Conversation
This will have to be updated to #1800 and requires a bit of cleanup in the |
fbd0c9a
to
fb0ad6f
Compare
* master: feat(metrics): Count transactions toward root project [TET-627] (#1734)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me, just one remark about the test config.
relay-replays/src/recording.rs
Outdated
fn default_pii_config() -> PiiConfig { | ||
let mut pii_config = PiiConfig::default(); | ||
pii_config.applications = [(SelectorSpec::And(vec![]), vec!["@common".to_string()])].into(); | ||
pii_config | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To have the tests resemble the default production use case, I would use a configuration derived from DataScrubbingConfig
here, like for example
relay/relay-general/src/protocol/replay.rs
Lines 554 to 560 in afa6576
fn simple_enabled_config() -> DataScrubbingConfig { | |
let mut scrub_config = DataScrubbingConfig::default(); | |
scrub_config.scrub_data = true; | |
scrub_config.scrub_defaults = true; | |
scrub_config.scrub_ip_addresses = true; | |
scrub_config | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated. This actually shows us that the filter has changed.
@cmanallen note that email addresses aren't being scrubbed anymore, apparently the default data scrubbers don't do this. No action item imho, this is in line with the other data scrubbers.
Yes. I was waiting for a response on #1731 (comment). Merging now. |
Removes statically defined scrubbers with data scrubbing and PII config from the project state. This includes a refactor that moves replay scrubbing on a struct.
closes: https://github.com/getsentry/replay-backend/issues/243