fix(profiling): Warn on invalid JSON errors #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
approved these changes
Dec 8, 2022
jan-auer
approved these changes
Dec 8, 2022
| @@ -3,13 +3,15 @@ use crate::ProfileError; | |||
| pub fn discard_reason(err: ProfileError) -> &'static str { | |||
| match err { | |||
| ProfileError::CannotSerializePayload => "profiling_failed_serialization", | |||
| ProfileError::InvalidBase64Value => "profiling_invalid_base64_value", | |||
| ProfileError::InvalidJson(_) => "profiling_invalid_json", | |||
There was a problem hiding this comment.
We should use the existing discard reasons for this, such as DiscardReason::InvalidJson to keep cardinality of the column overall as low as possible. However, we can also follow up about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like the error to be logged but not sent to Sentry as it's high cardinality and not very useful in Sentry.
Changing it to a warn level log seems to log in Cloud Logging but not send anything to Sentry, which is the behavior we'd like to have.