feat(replays): Add non-chunked recording message type #1653
+180
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmanallen there is a failing integration test, that seems to be a good spot to add test coverage. |
|
@cmanallen could you add some motivation for this change to the PR description? Is it an optimization to reduce the number of messages? |
|
@jjbayer Updated. |
jjbayer
reviewed
Dec 13, 2022
jjbayer
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization to allow greater parallelization in our consumer. A single message containing the payload does not require ordering guarantees and can be processed in a process pool or thread pool.