-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(general): Added basic snapshot tests for normalize and event parsing #154
Conversation
general/src/types/annotated.rs
Outdated
Deserialize::deserialize(deserializer)?, | ||
Default::default(), | ||
)) | ||
self.serialize_with_meta(serializer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break for non-struct types. I'd say we remove this impl completely, as one should always go through the helper methods.
Looks like on Travis it can't invoke this correctly and fails with a panic: https://github.com/mitsuhiko/insta/blob/901b5093c9dae7c53d62023301b4ae8bfe878e32/src/runtime.rs#L61-L67
After that the Workspace mutex is poisoned and fails subsequently. |
…re into feature/snapshot-tests
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=========================================
+ Coverage 58.18% 59.5% +1.32%
=========================================
Files 83 84 +1
Lines 8991 8997 +6
=========================================
+ Hits 5231 5354 +123
+ Misses 3760 3643 -117
Continue to review full report at Codecov.
|
No description provided.