fix(metrics): Parse custom units #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Jun 20, 2022
Co-authored-by: Markus Unterwaditzer <[email protected]>
iker-barriocanal
approved these changes
Jun 20, 2022
Co-authored-by: Iker Barriocanal <[email protected]>
flub
reviewed
Jun 20, 2022
relay-common/src/constants.rs
Outdated
| let mut unit = Self(Default::default()); | ||
| unit.0.copy_from_slice(s.as_bytes()); | ||
| let mut unit = Self([0; CUSTOM_UNIT_MAX_SIZE]); | ||
| unit.0[..s.len()].copy_from_slice(s.as_bytes()); |
There was a problem hiding this comment.
I'd probably try and avoid indexing operations, using .get() or so instead. IIRC it's also possible to add a clippy lint for this.
There was a problem hiding this comment.
you could use unit.0.get(..s.len()).ok_or(ParseMetricUnitError())? and forego the s.len() check on line 490 (but still leave the is_ascii check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser of
CustomUnitonly worked when the length of the custom unit was exactly 15.Fixes POP-RELAY-2GF.