Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Log statsd metrics for bucket flushing #1070

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Aug 31, 2021

Introduces new internal metrics to measure the pressure and performance
on the metric bucket flush cycle:

  1. metrics.buckets.scan_duration: Time in milliseconds spent scanning
    metric buckets to flush.
  2. metrics.buckets.flushed: The total number of metric buckets flushed
    in a cycle across all projects.
  3. metrics.buckets.flushed_per_project: The number of metric buckets
    flushed in a cycle for each project.
  4. metrics.buckets: The total number of metric buckets in Relay's
    metrics aggregator.

@jan-auer jan-auer requested a review from a team August 31, 2021 13:26
@RaduW RaduW self-requested a review August 31, 2021 13:52
Copy link
Contributor

@RaduW RaduW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jan-auer jan-auer merged commit c9be9d6 into master Aug 31, 2021
@jan-auer jan-auer deleted the feat/metrics-metrics branch August 31, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants