Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align PII data scrubbing in span.data and breadcrumb.data #1915

Closed
iker-barriocanal opened this issue Mar 9, 2023 · 1 comment
Closed

Align PII data scrubbing in span.data and breadcrumb.data #1915

iker-barriocanal opened this issue Mar 9, 2023 · 1 comment
Assignees

Comments

@iker-barriocanal
Copy link
Contributor

#1855 requests PII scrubbing specific fields in span.data and breadcrumb.data. Looking at data in the protocol, in breadcrumbs is undefined what the parameters are, but spans have it more defined and it's expected to follow OpenTelemetry's semantics.

In some case, such as in here, we're scrubbing breadcrumb data fields where it doesn't really make sense for an IP address to be, with the goal to remove all PII sensitive data that may have accidentally been leaked. However, this is not the case in spans.

This brings us to some questions about what the behavior should be, and what should relay do. Is there any reason not to PII scrub the whole data objects in spans and breadcrumbs? Is there any reason not to align the PII data scrubbing behavior of spans and breadcrumbs?

@iker-barriocanal
Copy link
Contributor Author

We decided to follow what this issue suggests -- to not type all the structured data in span.data and breadcrumb.data, and perform PII scrubbing in the whole objects. We'll monitor the effects and take action accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant