Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold markdown in Dashboard Textbox not rendered correctly #4070

Closed
griffinator76 opened this issue Aug 14, 2019 · 7 comments
Closed

Bold markdown in Dashboard Textbox not rendered correctly #4070

griffinator76 opened this issue Aug 14, 2019 · 7 comments

Comments

@griffinator76
Copy link

griffinator76 commented Aug 14, 2019

Issue Summary

Textbox in Dashboard is supposed to support markdown as per https://www.markdownguide.org/cheat-sheet/#basic-syn (linked to from Textbox editor)

Bold markdown syntax doesn't appear to work though, in preview or in saved Textbox:

image

Bold text is not rendered as bold, also preceding new line is ignored.

Steps to Reproduce

  1. Create a Dashboard
  2. Add a Textbox
  3. Enter some text and encapsulate in bold markdown syntax e.g. **this is bold text**
  4. Save
  5. Text is not displayed as bold

Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?

Expected behaviour: using markdown produces bold text

Technical details:

  • Redash Version: 7.0.0+b18042 (4a978ba)
  • Browser/OS: Firefox 60.8.0esr (64-bit) / Amazon Linux (Workspace)
  • How did you install Redash: Self hosted on Kubernetes
@gabrieldutra
Copy link
Member

Hi @griffinator76, thanks for reporting, happily this seems to be already fixed in #3686 and should arrive soon in Redash v8 😁. You can confirm whether this is working in our preview environment.

@griffinator76
Copy link
Author

Thanks! Sorry, I searched for existing markdown issues but didn't see that one for some reason.

@arikfr
Copy link
Member

arikfr commented Aug 15, 2019

Btw, this is how your example looks like with v8:

image

@gabrieldutra
Copy link
Member

In any case, "also preceding new line is ignored" seems to still be there 😕.

@kravets-levko
Copy link
Collaborator

also preceding new line is ignored

@griffinator76 (cc @gabrieldutra) It's okay: single newline is treat as whitespace. If you want to start a new paragraph, you have to add one more newline before it. So it should look like this:

some text
**bold text**

---

*italics*

> blockquote

**more bold**

@arikfr
Copy link
Member

arikfr commented Aug 15, 2019

you have to add one more newline before it. So it should look like this:

That or add two spaces at the end of the line.

@gabrieldutra
Copy link
Member

Closing as this issue is fixed in Redash v8 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants