Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dashboard owner on detail page #2832

Open
jezdez opened this issue Sep 17, 2018 · 8 comments
Open

Show dashboard owner on detail page #2832

jezdez opened this issue Sep 17, 2018 · 8 comments

Comments

@jezdez
Copy link
Member

jezdez commented Sep 17, 2018

Issue Summary

When viewing a dashboard there is no indication of the owner of the dashboard, which may be useful for feedback in an organization for example. We're already showing the owner in the list view, so this could be considered a UI inconsistency.

This was originally filed downstream in mozilla#353.

Steps to Reproduce

  1. Go to a detail page of a dashboard
  2. See the name of the user missing

Technical details:

  • Redash Version: 5.0beta
  • Browser/OS: Firefox 62, macOS 10.13
  • How did you install Redash: Docker
@arikfr
Copy link
Member

arikfr commented Sep 17, 2018

Definitely makes sense. @kocsmy can you suggest a design?

@kocsmy
Copy link
Collaborator

kocsmy commented Oct 10, 2018

I have 3 ideas where could we show the dashboard owner:

  1. Dashboard header: after the name / tags, we could show a profile picture with the owner. This could be only shown on hover (similar to add tag) so it won't pollute the interface that much.
  2. Extra last row after visualizations: we could also use this space to add more information: Created by [profile pics]Arik Fraimovich on 4th of May, 2018, Last edited etc
  3. Dashboard info modal which can be reached from the ... menu on the top right corner. We could also place more things here.

I think the option 2 and 3 makes the most sense for me as we could use that space for much more in the future.

@arikfr
Copy link
Member

arikfr commented Oct 10, 2018

Why not a line below the header before the content?

@kocsmy
Copy link
Collaborator

kocsmy commented Oct 10, 2018

I don't think this is such an important detail that justifies pushing the content further down.

@arikfr
Copy link
Member

arikfr commented Oct 10, 2018

Then let's go with option 2.

@kocsmy
Copy link
Collaborator

kocsmy commented Oct 10, 2018

Ok, I'll get started with it.

@kocsmy
Copy link
Collaborator

kocsmy commented Oct 12, 2018

How about a section like this?

image

  • I think this opens up some space for other details for example last edited time.
  • I tried it without a background but I kind alike having this slight grey tone / this might be not the best choice though as it looks very similar to our secondary button design. Might need to make it less grey.

@kocsmy
Copy link
Collaborator

kocsmy commented Oct 12, 2018

PR open here #2934

@arikfr arikfr added the backlog label Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants