Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: merge dashboard and public-dashboard #2076

Closed
kravets-levko opened this issue Nov 7, 2017 · 4 comments · Fixed by #4228
Closed

Refactoring: merge dashboard and public-dashboard #2076

kravets-levko opened this issue Nov 7, 2017 · 4 comments · Fixed by #4228
Assignees

Comments

@kravets-levko
Copy link
Collaborator

Currently there are two pages to display dashboard: dashboard and public-dashboard. First one is an extended version of the second, but with additional controls (editing, sharing, etc.). Since there is a lot of duplicated code, the idea is to merge that two pages (via extracting common code into components, services, etc.) and keep all logic related to dashboards in the single place.

@deecay
Copy link
Contributor

deecay commented Nov 26, 2017

+1 for this. And by doing that, I would like to see dashboard level filters available in public dashboards. This is a key feature for me.

@s1moe2
Copy link

s1moe2 commented Nov 13, 2018

+1 here for the exact same reasons that @deecay mentioned. Having the dashboard level filters available in public dashboards is super useful, specially because having individual filters on each visualisation completely breaks the user experience, in my opinion (if you have multiple visualisations)

@kravets-levko
Copy link
Collaborator Author

@gabrieldutra Please close this issue after #4228 and #4203 merged. Thanks!

@gabrieldutra
Copy link
Member

Yeah, I'm kind of solving this issue in those PRs. Thanks for pointing this @kravets-levko! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants