Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit parameters on Windows #1241

Closed
jasmdk opened this issue Sep 2, 2020 · 3 comments
Closed

Unable to edit parameters on Windows #1241

jasmdk opened this issue Sep 2, 2020 · 3 comments
Labels
bug Oops, sorry!

Comments

@jasmdk
Copy link
Contributor

jasmdk commented Sep 2, 2020

Describe the bug

It is possible to generate a parameter set using porter parameters generate but when trying to edit it afterwards with porter parameters edit it fails

To Reproduce

Steps to reproduce the behavior:

  1. Run porter parameters generate myparams
  2. Use any porter.yaml that defines one or more parameters
  3. Run this porter command porter parameters edit myparams
  4. See error
/C: /C: Is a directory
Error: unable to open editor to edit parameter set: exit status 126

Expected behavior

An interactive editor that allows for updating and/or adding missing parameters in the existing parameter set

Porter Command and Output

$ porter parameters edit myparams
/C: /C: Is a directory
Error: unable to open editor to edit parameter set: exit status 126

The "C:" part probably relates to the fact that I'm running under Windows, where porter gets installed in "C:\Users<initials>.porter\porter"

Version

Copy the output of porter version below

porter v0.28.1 (dd9056f)

@jasmdk jasmdk added the bug Oops, sorry! label Sep 2, 2020
@carolynvs
Copy link
Member

I wasn't able to reproduce this on Windows using Powershell or WSL2 with v0.29.1 but we haven't made any recent changes that would have fixed it.

Are you still able to reproduce this error? If so, which shell are you using and are on Windows or are you in WSL?

What is the value of your EDITOR and SHELL environment variables? If you have EDITOR set, can you try unsetting it then re-running the command again? I'm wondering if perhaps your editor and shell are misaligned, so that Porter is trying to open a windows formatted path in bash, or vice versa.

@jasmdk
Copy link
Contributor Author

jasmdk commented Nov 4, 2020

I can not reproduce it and we implemented another solution to not manage parametersets directly, especially because we have a set of bundles that shares some of the same configuration values.
You may close this for all I care.

@carolynvs
Copy link
Member

I'm glad to hear that you have a workaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oops, sorry!
Projects
None yet
Development

No branches or pull requests

2 participants