fix: SUMMARY_MAX_PARAGRAPHS not respected in some combinations with SUMMARY_MAX_LENGTH

[scolby33]

When, for example, the content is 2 paragraphs, each consisting of 30 words, and SUMMARY_MAX_PARAGRAPHS=1 and SUMMARY_MAX_LENGTH=50, the current behavior produces a summary with 50 words and 2 paragraphs, effectively ignoring SUMMARY_MAX_PARAGRAPHS.

This change inverts this behavior: the resulting summary from the above situation will consist of the entire first 30 word paragraph.

In the case where the first paragraph(s) is longer than SUMMARY_MAX_LENGTH, the summary will still be truncated to that length.

This change brings the actual behavior in line with the documented behavior.

Pull Request Checklist

• Ensured tests pass and (if applicable) updated functional test output
• Conformed to code style guidelines by running appropriate linting tools
• Added tests for changed code
• Updated documentation for changed code no need for documentation changes

[justinmayer]

Thank you, Scott, for submitting this pull request — replete with a test, no less! ✨

Given the narrow scope of these changes, I think a release type of patch would be more appropriate. Would you please change the release file accordingly?

@gagath: As the original author of the SUMMARY_MAX_PARAGRAPHS setting, do you have any comments on this PR?

[scolby33]

@justinmayer no problem, changed the release type in the latest version!

[gagath]

Hello @justinmayer and @scolby33, this change looks good to me and indeed fixes an implementation error of SUMMARY_MAX_PARAGRAPHS=1 not being honored if the paragraph length is too short. Thanks for the fix!

[justinmayer]

Many thanks to @scolby33 for the enhancement and to @cthoyt & @gagath for reviewing! 🏅

[cthoyt]

@justinmayer not relevant to the PR but @scolby33 and I are flatmates and we thought it was funny we both had random PRs for two of your different projects back to back. Cheers!

[justinmayer]

No way! 😮 That is indeed quite funny — literally laughed out loud when I read it.

It’s been a pleasure. I hope there will be more random open-source encounters with y’all in the future. If you’re ever in the Italian Alps, beers are on me! 🍻