Remove Posterous integration #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaris
reviewed
Oct 5, 2023
Posterous closed down in 2013. The API is no longer accessible and the code did not work in python 3 (base64.encodestring was expecting bytes, not string)
mart-e
force-pushed
the
remove-posterous
branch
from
5f5394d
to
5d8c031
Compare
pauloxnet
approved these changes
Oct 6, 2023
justinmayer
approved these changes
Oct 7, 2023
justinmayer
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Many thanks to @mart-e for this enhancement and to @avaris and @pauloxnet for reviewing. 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first my intention was to replace the
base64.encodestringbybase64.encodebytes(the former has been removed in python 3.11) but I realised this code was actually not working.This PR is a suggestion to fully remove the Posterous import.
Posterous closed down in 2013.
The API is no longer accessible and the code did not work in python 3 (
base64.encodestringwas expecting bytes, not string)Pull Request Checklist