Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed importing savepoints #6406

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Sep 10, 2024

Closes #6405

Why is this the best possible solution? Were any other approaches considered?

There is not much to discuss here. The form name should be escaped so that it is treated as literal text when used in a regular expression pattern.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I've only modified the regex used to identify savepoints associated with the given form names. This change shouldn't affect the existing implementation, it simply resolves the issue.

Here are the apks for testing: https://drive.google.com/file/d/14hDAkrEGU6MoGZsj3cJDorib9KnuEZzL/view?usp=sharing

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 changed the title Collect 6405 Fixed importing savepoints Sep 10, 2024
@grzesiek2010 grzesiek2010 merged commit 0755830 into getodk:master Sep 12, 2024
6 checks passed
@dbemke
Copy link

dbemke commented Sep 13, 2024

Tested with Success!

Verified on a device with Android 10

Verified Cases:

@WKobus
Copy link

WKobus commented Sep 13, 2024

Tested with Success!

Verified on device with Android 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrectly nested parentheses in regexp pattern
4 participants