Remove withIndex usage from flakey test #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
requested changes
Sep 2, 2024
| @@ -150,8 +150,7 @@ class SendFinalizedFormTest { | |||
|
|
|||
| .clickSendFinalizedForm(2) | |||
| .sortByDateNewestFirst() | |||
| .selectForm(0) | |||
| .selectForm(1) | |||
| .clickSelectAll() | |||
There was a problem hiding this comment.
Here we wanted to make sure that the older form was being sent first and to do that we selected the newer one first. If we use the select all option it is not guaranteed right? Probably it works like that and selects forms starting from the top of the list but it's not obvious. Can we improve it somehow?
There was a problem hiding this comment.
I think this is a good compromise for now: reversing the order causes a fail, and it avoids using the problematic matcher. I definitely agree that selecting them individually provides a bit more coverage, but we'd need to write a new implementation of selectForm that I didn't want to spend time on vs other things.
grzesiek2010
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecated
withIndexmethod use from a flakey test. It appeared (from the video) the test was having problems clicking on the second form.