Stream CSV when processing server entities #6353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6350
Blocked by getodk/javarosa#792This removes the CSV to XML parsing that was being performed and instead just parses the instance CSV directly as a stream which should improve the memory footprint when downloading entity forms. There may be a slight speed up as well as we don't convert the CSV to an in-mem XML representation, but this will be minor at best.
Why is this the best possible solution? Were any other approaches considered?
Not a lot to discuss here!
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The main risk will be to forms with entities (follow up and update forms). Nothing else should be affected. The only device that predictably experienced OOMs was @lognaturel's Galaxy A13, so let's let her confirm that this fixes that.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest