Fixed buttons that are blocked too long #6098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
changed the title
seadowg
requested changes
Apr 23, 2024
| defStyleAttr | ||
| ) | ||
| init { | ||
| context.theme.obtainStyledAttributes( |
There was a problem hiding this comment.
Could we add a helper to ContextUtils for grabbing theme string theme attributes like this?
There was a problem hiding this comment.
Actually, kotlin offers an extension function called withStyledAttributes so we can use it ffa8c79
grzesiek2010
force-pushed
the
COLLECT-6061
branch
from
4c23035 to
7dedf2a
Compare
grzesiek2010
force-pushed
the
COLLECT-6061
branch
from
7dedf2a to
331b2ab
Compare
seadowg
approved these changes
Apr 24, 2024
|
Tested with Success! Verified on device with Android 12,13 Verified cases:
|
|
Tested with Success! Verified on device with Android 10 |
|
Tested with Success! Verified on device with Android 11 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6061
Why is this the best possible solution? Were any other approaches considered?
As discussed in the issue there are two approaches we can use depending on our needs:
MultiClickSafeMaterialButtonif we have multiple buttons on one screen and we don't want to block them. Here a good example is the navigation buttons or the control buttons that we use to select/unselect/delete forms.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This should fix the problem with the navigation buttons and the buttons that control lists of forms (select/unselect/delete). Nothing else should be affected. It's possible that other places in the app might need similar changes but we can identify them later and file separate issues.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still pass