Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed setting background color used in pills #5927

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jan 19, 2024

Closes #5926

Why is this the best possible solution? Were any other approaches considered?

It looks like our getThemeAttributeValue method does not work well with colors that are defined as selectors. I could have tried to improve that method but it doesn't make sense if MaterialColors provides one that works well.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Please verify that the background color used in the pills with Errors/No Errors messages is correct. Nothing else can be affected since the changes are only in that one place where those two pills are generated.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review January 19, 2024 12:04
@grzesiek2010 grzesiek2010 requested a review from seadowg January 19, 2024 12:04
@seadowg seadowg merged commit 064f926 into getodk:master Jan 23, 2024
6 checks passed
@dbemke
Copy link

dbemke commented Jan 24, 2024

Tested with Success!

Verified on devices with Android: 8.1, 10

Verified cases:

  • colors in pills errors and no errors
  • light and dark mode
  • RTL language
  • quick checks in validation and bulk finalization

@srujner
Copy link

srujner commented Jan 24, 2024

Tested with Success!

Verified on devices with Android: 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors/No errors pill in Drafts list is missing background color
4 participants