Fix killAndReopenApp
#5907
Merged
Fix killAndReopenApp
#5907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
force-pushed
the
killAndReopenApp
branch
from
7233731 to
e266baf
Compare
seadowg
commented
Jan 15, 2024
| clickOnSelectedLanguage(language); | ||
| } | ||
|
|
||
| onData(equalTo(language)).perform(click()); |
There was a problem hiding this comment.
I changed this as I ran into flakes with clickOnSelectedLanguage while testing my changes to killAndReopenApp.
seadowg
force-pushed
the
killAndReopenApp
branch
from
6a69b71 to
9e80ee7
Compare
grzesiek2010
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5899
The core change here was to move the code that deals with dismissing the tooltip to
PrepDeviceForTestRuleand to deal with it in a new task rather than the task being used for the current test flow. The idea here is to reduce the risk of running into problems by not interfering with the test task and also by reducing the amount of times theUIDevicecode will actually need to run.I've run this multiple times and not seen flakes locally or on Test Lab.