Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display the option to finalize drafts in the list of sent forms #5862

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Dec 1, 2023

Closes #5857

Why is this the best possible solution? Were any other approaches considered?

We share the same activity class to display the list of drafts and the list of sent forms so if we want to have different behavior between those two lists we need to use the editMode flag.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It's a safe fix so testing the scenario described in the issue should be enough.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg merged commit 8e664b1 into getodk:master Dec 13, 2023
6 checks passed
@srujner
Copy link

srujner commented Jan 4, 2024

Tested with Success!

Issue #5857 is no longer reproducing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Finalize all drafts" in Sent
3 participants