Removed Stamen maps

[grzesiek2010]

Closes #5806

Why is this the best possible solution? Were any other approaches considered?

This is what we agreed on. We don't think Stamen maps are very popular among our users so we can get rid of them.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I think we need to test:

• that Stamen maps are not available now
• upgrading from a version with Stamen maps selected in settings (this should be migrated to OSM)
• scanning/importing QR codes with Stamen maps on an apk where they are removed (this pr)

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• added a comment above any new strings describing it for translators
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[dbemke]

What is the expected in this case? I created (via reconfigure QR code) a QR code in 2023.3.0 of the demo project with Stamen maps. I installed Collect with the PR version (build in AS- with maps available) and added a new project by scanning the created QR code. The result in the PR version is that Google maps are source of maps.
So what is the default map instead of Stamen maps when there is an app with all maps are available (apk built in Android Studio) and an app without all token for maps (CircleCi apk- this changes Stamen to Google and Google to OSM as Google in not available?)?

[grzesiek2010]

What is the expected in this case? I created (via reconfigure QR code) a QR code in 2023.3.0 of the demo project with Stamen maps. I installed Collect with the PR version (build in AS- with maps available) and added a new project by scanning the created QR code. The result in the PR version is that Google maps are source of maps.
So what is the default map instead of Stamen maps when there is an app with all maps are available (apk built in Android Studio) and an app without all token for maps (CircleCi apk- this changes Stamen to Google and Google to OSM as Google in not available?)?

as long as Google Maps are available I would say it's not a big deal although it was supposed to use OSM... could you give it a try now?

[dbemke]

Tested with Success!

Verified on a device with Android 10

Verified cases:

• As of July 31, 2023, Stamen Map Tiles are served by Stadia Maps #5806
• Stamen maps aren’t available
• adding a project and reconfiguring a project with a QR code with Stamen maps
• importing a QR code with Stamen maps
• updating Collect with a project w Stamen maps
• resetting a project in which Stamen maps were in settings before migrating to OSM

[srujner]

Tested with Success!

Verified on a device with Android 13