Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Access control > Form Entry Settings > Save Form #5580

Closed
lognaturel opened this issue May 12, 2023 · 0 comments · Fixed by #5610
Closed

Rename Access control > Form Entry Settings > Save Form #5580

lognaturel opened this issue May 12, 2023 · 0 comments · Fixed by #5610
Assignees
Milestone

Comments

@lognaturel
Copy link
Member

lognaturel commented May 12, 2023

The existing "Save Form" setting is in a section called "Uncheck to hide from Form Entry". Unchecking it hides the save button from the top bar and the "Save as draft" button from the form exit modal.

It's really not clear what to expect this setting to do, especially now that the setting after it is called "Save as draft".

I propose the following changes:

  1. Rename "Save Form" to "Save as draft" and add subtext "Save icon in top bar and "Save as draft" button when exiting form"
  2. Add a section header below it called "Uncheck to hide from Form End". That will contain "Save as draft" and "Finalize"

This reinforces the new language and matches the new code structure where form end and form entry are more separate.

A further change we could consider is separating the two concepts that are currently linked: we could have "Save icon" and "Save as draft" with subtext "In dialog when exiting form". We could migrate the existing "Save Form" setting to uncheck both settings if it's unchecked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

2 participants