Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero at the beginning of version number is removed on 'Get Blank Form' page #2296

Closed
mmarciniak90 opened this issue Jun 13, 2018 · 22 comments
Closed
Assignees
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) in progress

Comments

@mmarciniak90
Copy link
Contributor

Software and hardware versions

Collect 1.15.0

Problem description

0 at the beginning of version number is removed on Get Blank Form page

Steps to reproduce the problem

  1. The user wants to download form with version="00001" multi-warning.xml.txt
  2. The user goes to Get Blank Form page
  3. The user sees that form has Version 1
screenshot_20180613-155143 screenshot_20180613-155208 screenshot_20180613-155212

Expected behavior

  • The user should see the correct version number, zero should not be removed
  • Fill Blank Form' page and Delete Saved Form` page show correct version number
@grzesiek2010
Copy link
Member

@opendatakit-bot label "good first issue"

@getodk-bot getodk-bot added the good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) label Jun 13, 2018
@SaumiaSinghal
Copy link
Contributor

@opendatakit-bot claim

@grzesiek2010
Copy link
Member

Hey @SaumiaSinghal I think you solved enough good first issues an you are ready to take something more complex so maybe please leave it for someone completely new

@SaumiaSinghal
Copy link
Contributor

Yes okay @grzesiek2010, I was also thinking it to be my last good first issue. I'll unclaim it.

@SaumiaSinghal
Copy link
Contributor

@opendatakit-bot unclaim

@surajdubey
Copy link

@opendatakit-bot claim

@getodk-bot
Copy link
Member

getodk-bot commented Jun 28, 2018

Hello @surajdubey, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@surajdubey
Copy link

@opendatakit-bot claim

@getodk-bot
Copy link
Member

getodk-bot commented Jul 16, 2018

Hello @MikeMikerson, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@surajdubey
Copy link

@opendatakit-bot claim

@getodk-bot
Copy link
Member

ERROR: You have already claimed this issue.

@getodk-bot
Copy link
Member

getodk-bot commented Jul 31, 2018

Hello @surajdubey, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@surajdubey
Copy link

@opendatakit-bot claim

@surajdubey
Copy link

@opendatakit-bot claim

@getodk-bot
Copy link
Member

ERROR: You have already claimed this issue.

@getodk-bot
Copy link
Member

getodk-bot commented Sep 11, 2018

Hello @surajdubey, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@MikeMikerson
Copy link

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @MikeMikerson! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

@cooperka
Copy link
Contributor

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @cooperka! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

@cooperka
Copy link
Contributor

Turns out this isn't a Collect issue, it's an Aggregate issue. The response sent back from the server for the Multi Warning form is:

<xform>
  <formID>multi warning</formID>
  <name>Multi Warning</name>
  <majorMinorVersion>1</majorMinorVersion>
  <version>1</version>
  <hash>md5:c1983e6a874af5cb49b4e484bfadb92d</hash>
  <downloadUrl>https://sandbox.aggregate.opendatakit.org/formXml?formId=multi+warning</downloadUrl>
</xform>

Whereas <version>500001</version> is correct when the leading character is non-zero. I'm leaving soon for a weekend out of town but I'll come back and set up Aggregate on Monday to dig deeper.

@lognaturel
Copy link
Member

Thank you, @cooperka! That makes sense. I think it would have been slightly higher priority as a client-side issue but seems to me as pretty low priority on the Aggregate side.

I'll leave you the honor of filing the issue there and we can see if anyone else thinks it's something to prioritize. Since you're all set up for Collect I'd recommend sticking around here for a bit! Getting an issue like this closed is super helpful. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) in progress
Projects
None yet
Development

No branches or pull requests

8 participants