Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of requests in SubmissionShow #770

Open
matthew-white opened this issue Apr 5, 2023 · 0 comments
Open

Reduce number of requests in SubmissionShow #770

matthew-white opened this issue Apr 5, 2023 · 0 comments
Labels
refactor Improves code without altering behavior

Comments

@matthew-white
Copy link
Member

In SubmissionShow, we request the OData for the submission, as well as the submission's first version. The only properties we use from the OData are __id, __system, and meta (for the instance name). The only information we use from the first version is the user agent. Now that getodk/central-backend#783 is in place, I think we could probably consolidate these two requests. I think if we request just the logical submission, that will include all the information we need, including the first user agent and the current instance name.

@matthew-white matthew-white added the refactor Improves code without altering behavior label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improves code without altering behavior
Projects
None yet
Development

No branches or pull requests

1 participant