feat: implement mock for S3Tables service #8470
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8470 +/- ##
==========================================
- Coverage 92.63% 92.62% -0.01%
==========================================
Files 1224 1229 +5
Lines 105922 106340 +418
==========================================
+ Hits 98120 98497 +377
- Misses 7802 7843 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
felixscherz
force-pushed
the
feat/s3tables
branch
from
16f75a4 to
6752429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is in regards to #8422.
I used
scripts/scaffold.pyto setup thes3tablesservice. I had to modify some URL patterns for the S3 service, as they overlap with s3tables.Supported methods:
create_table_bucketget_table_bucketlist_table_bucketsdelete_table_bucketcreate_namespacedelete_namespacelist_namespacescreate_tableget_tablelist_tablesdelete_tableupdate_metadata_locationget_metadata_locationrename_tabledelete_table_bucket_policydelete_table_policyget_table_bucket_maintenance_configurationget_table_bucket_policyget_table_maintenance_configurationget_table_maintenance_job_statusget_table_policyput_table_bucket_maintenance_configurationput_table_bucket_policyput_table_maintenance_configurationput_table_policyCurrently working on supporting the new type of S3 buckets within the existing S3 backend so that data can be written to/read from S3 tables.