Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Replacing webpack in favour of vite #1929

Open
ManiacMaxo opened this issue Dec 20, 2024 · 2 comments · May be fixed by #1944
Open

[FEAT] Replacing webpack in favour of vite #1929

ManiacMaxo opened this issue Dec 20, 2024 · 2 comments · May be fixed by #1944
Labels
🛠 feature New feature or request

Comments

@ManiacMaxo
Copy link

Porting the frontend to vite from the current webpack would have many quality of life improvements - you'd get faster development build times, leaner bundles, simpler configuration and its rich plugin ecosystem. In my mind there is no reason to stay on webpack as most new developers start with vite so it won't be a problem to keep maintaining it.

If you're open to the idea I have already implemented it at ManiacMaxo/lago-front and can open a PR for it.

@ManiacMaxo ManiacMaxo added the 🛠 feature New feature or request label Dec 20, 2024
@ansmonjol
Copy link
Collaborator

ansmonjol commented Dec 23, 2024

Hey @ManiacMaxo 👋

Thanks for your proposal. We indeed intent to migrate to use Vite. We just needed to find the correct timing between feature development and improvements!
Also IIRC there were one of our Webpack plugging that were either not existing yet for Vite, or useless, and I don't remember which one 😅 .

Of course all contributions are welcome! And we can probably help with that too.
For example we'll make sure this migration does not break our internal deployment scripts for our cloud platform once you opened the PR.
I cannot guarantee our availability during this end of the year period, but we'll look at it for sure :)

@ManiacMaxo
Copy link
Author

That's great! I'll try to work on reducing the bundle size, since it currently outputs a 3MB index.js and I'll open a PR later this/next week :)

@ManiacMaxo ManiacMaxo linked a pull request Dec 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants