Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] Extension of k-page-view component in plugin fails #5183

Closed
Tracked by #12
tobimori opened this issue May 25, 2023 · 0 comments · Fixed by #5202
Closed
Tracked by #12

[v4] Extension of k-page-view component in plugin fails #5183

tobimori opened this issue May 25, 2023 · 0 comments · Fixed by #5202
Assignees
@distantnative
Labels
type: regression 🚨 Is a regression between versions
Milestone
4.0.0-alpha.2

Comments

@tobimori
Copy link
Contributor

Description

My SEO plugin kirby-seo is extending the k-page-view component to show a simple robots indicator in the title bar. The code can be found here. With Kirby 4, the Component is not able to be registered and throws an error:
CleanShot 2023-05-25 at 11 36 55@2x

To reproduce

Install Kirby 4 Beta and my kirby-seo plugin.

Your setup

Kirby Version 4.0-alpha.1
@distantnative distantnative added this to the 4.0.0 milestone May 25, 2023
@distantnative distantnative added the type: regression 🚨 Is a regression between versions label May 25, 2023
This was referenced May 25, 2023
Closed
Closed
@rasteiner rasteiner mentioned this issue May 26, 2023
Closed
@distantnative distantnative self-assigned this May 29, 2023
distantnative added a commit that referenced this issue May 29, 2023
@distantnative
Fix enxtending Vue components
856b095 
Fixes #5183
@distantnative distantnative mentioned this issue May 29, 2023
Merged
5 tasks
@distantnative distantnative linked a pull request May 29, 2023 that will close this issue
Fix extending Vue components #5202
Merged
5 tasks
@distantnative distantnative modified the milestones: 4.0.0, 4.0.0-alpha.2 May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distantnative distantnative

Labels
type: regression 🚨 Is a regression between versions
Projects
None yet
Milestone
4.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

Fix extending Vue components getkirby/kirby
3 participants
@bastianallgeier @distantnative @tobimori