From 414d37728bb1b3f2e56f301d97b7baabd251a24a Mon Sep 17 00:00:00 2001 From: Pierre Fenoll Date: Mon, 19 Jun 2023 14:57:26 +0200 Subject: [PATCH] ouip Signed-off-by: Pierre Fenoll --- openapi3/loader.go | 3 --- openapi3/operation.go | 2 +- openapi3/refs_test.go | 16 ++++++++-------- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/openapi3/loader.go b/openapi3/loader.go index 59dfdf1bf..2813f455f 100644 --- a/openapi3/loader.go +++ b/openapi3/loader.go @@ -398,9 +398,6 @@ func drillIntoField(cursor interface{}, fieldName string) (interface{}, error) { case *Paths: cursor = c.m // m map[string]*PathItem - // default: - // fmt.Printf(">>> %T \n", cursor) - case *SchemaRef: if fieldName == "additionalProperties" { if ap := c.Value.AdditionalProperties.Has; ap != nil { diff --git a/openapi3/operation.go b/openapi3/operation.go index b4d1ad7b1..6ce1df9df 100644 --- a/openapi3/operation.go +++ b/openapi3/operation.go @@ -171,7 +171,7 @@ func (operation *Operation) AddResponse(status int, response *Response) { code = strconv.FormatInt(int64(status), 10) } if operation.Responses == nil { - operation.Responses = &Responses{} + operation.Responses = NewResponses() } operation.Responses.Set(code, &ResponseRef{Value: response}) } diff --git a/openapi3/refs_test.go b/openapi3/refs_test.go index 9d6f03d0e..e328c33eb 100644 --- a/openapi3/refs_test.go +++ b/openapi3/refs_test.go @@ -242,32 +242,32 @@ components: v, kind, err = ptr.Get(doc) require.NoError(t, err) require.NotNil(t, v) - require.IsType(t, PathItem{}, v) - require.Equal(t, reflect.TypeOf(PathItem{}).Kind(), kind) + require.IsType(t, &PathItem{}, v) + require.Equal(t, reflect.TypeOf(&PathItem{}).Kind(), kind) ptr, err = jsonpointer.New("/paths/~1pet/put") require.NoError(t, err) v, kind, err = ptr.Get(doc) require.NoError(t, err) require.NotNil(t, v) - require.IsType(t, Operation{}, v) - require.Equal(t, reflect.TypeOf(Operation{}).Kind(), kind) + require.IsType(t, &Operation{}, v) + require.Equal(t, reflect.TypeOf(&Operation{}).Kind(), kind) ptr, err = jsonpointer.New("/paths/~1pet/put/responses") require.NoError(t, err) v, kind, err = ptr.Get(doc) require.NoError(t, err) require.NotNil(t, v) - require.IsType(t, Responses{}, v) - require.Equal(t, reflect.TypeOf(Responses{}).Kind(), kind) + require.IsType(t, &Responses{}, v) + require.Equal(t, reflect.TypeOf(&Responses{}).Kind(), kind) ptr, err = jsonpointer.New("/paths/~1pet/put/responses/200") require.NoError(t, err) v, kind, err = ptr.Get(doc) require.NoError(t, err) require.NotNil(t, v) - require.IsType(t, Response{}, v) - require.Equal(t, reflect.TypeOf(Response{}).Kind(), kind) + require.IsType(t, &Response{}, v) + require.Equal(t, reflect.TypeOf(&Response{}).Kind(), kind) ptr, err = jsonpointer.New("/paths/~1pet/put/responses/200/content") require.NoError(t, err)