Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enrichPostData doesn't work with form encoded data #671

Closed
aciccarello opened this issue Nov 12, 2023 · 1 comment · Fixed by #672
Closed

enrichPostData doesn't work with form encoded data #671

aciccarello opened this issue Nov 12, 2023 · 1 comment · Fixed by #672
Assignees
Labels
bug Something isn't working plugin-endpoint Endpoint plug-in
Milestone

Comments

@aciccarello
Copy link

Description of the bug

I could be wrong but I think the enrichPostData option doesn't work if the micropub client sends data as form encoded rather than JSON.

https://github.com/getindiekit/indiekit/blob/be3a25f390b3d6065a9e48ed1778beca0eda8875/packages/endpoint-micropub/lib/controllers/action.js#L45C1-L47

Steps to reproduce

Post a like via https://quill.p3k.io/ of a post with mf2

Expected behaviour

jf2 data is included in the references of the post

Environment

Additional context

No response

@paulrobertlloyd
Copy link
Collaborator

Good spot! For a moment thought this was going to be a pain to fix, but the function already exists deep within the bowels of mf2tojf2, so was able to use that.

This fix will be released in the next beta version, though unsure when that might be yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin-endpoint Endpoint plug-in
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants