Support for asset collections and arrays #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for collections (named resources) of assets and arrays.
I did not really get what the previous code was supposed to do when the first parameter was an array. It wouldn't work since the actual call on Grav's asset instance would be
addAdd
( https://github.com/getgrav/grav-plugin-shortcode-core/blob/develop/shortcode-core.php#L194 ).While previously I had to do this:
With no possibility of overloading those assets. I can now do:
It also fixes the possibility of adding assets by array or string, similar to what Grav's Asset
add()
method does ( https://learn.getgrav.org/16/api#class-grav-common-assets )