Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taiko selector engineer and playwright #1548

Closed
roughsoft opened this issue Sep 28, 2020 · 2 comments
Closed

taiko selector engineer and playwright #1548

roughsoft opened this issue Sep 28, 2020 · 2 comments

Comments

@roughsoft
Copy link

If we can refactor the code make the taiko selector engineer and playwright side by side，It will be awesome.
@roughsoft
Copy link
Author

https://github.com/microsoft/playwright/blob/master/docs/extensibility.md#custom-selector-engines

@zabil
Copy link
Member

zabil commented Sep 28, 2020

We did look at this. I also see a comment at microsoft/playwright#2877 (comment)
However I am closing this as there is probably no refactoring to be done in Taiko to enable this. Its best tracked at the linked issue.

@zabil zabil closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zabil @roughsoft