Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed position remains in Closing #2142

Closed
bonomat opened this issue Mar 4, 2024 · 1 comment · Fixed by #2125
Closed

Closed position remains in Closing #2142

bonomat opened this issue Mar 4, 2024 · 1 comment · Fixed by #2125
Labels
bug Something isn't working critical

Comments

@bonomat
Copy link
Contributor

bonomat commented Mar 4, 2024

When closing a position off-chain the position on the coordinator side remains in Closing and the following error message is printed:

{"timestamp":"2024-03-04T06:31:43.553790864Z","level":"ERROR","fields":{"message":"Failed to process DLC message: Can't close position as contract is not closed.","from":"022b4974acc5463dc4077bc4a028bed3163c3472c97fa542aef0cd9c86593533e7","kind":"ChannelSettleFinalize"},"target":"coordinator::node"}
{"timestamp":"2024-03-04T06:31:43.550611872Z","level":"ERROR","fields":{"message":"Can't close position as contract is not closed.","trader_id":"022b4974acc5463dc4077bc4a028bed3163c3472c97fa542aef0cd9c86593533e7","protocol_id":"ProtocolId(8a58e6eb-76f1-454c-abd1-8e2f0d63e284)"},"target":"coordinator::node"}

How to reproduce:

  1. open new app
  2. fund wallet
  3. open position
  4. generate blocks manually and wait for being able to close position
  5. close position
  6. check coordinator DB

Reproduce locally and on our regtest setup with node id: 022b4974acc5463dc4077bc4a028bed3163c3472c97fa542aef0cd9c86593533e7

@bonomat bonomat added bug Something isn't working critical labels Mar 4, 2024
@bonomat
Copy link
Contributor Author

bonomat commented Mar 4, 2024

the dlc contract seems to be settled:

{
  "dlc_channel_id": "d4cfadc1b0442ca3cdb1dbafa8e20ddae7543a6e2ccd8387ac524fbc6ef1815f",
  "counter_party": "022b4974acc5463dc4077bc4a028bed3163c3472c97fa542aef0cd9c86593533e7",
  "channel_state": "Signed",
  "signed_channel_state": "Settled",
  "update_idx": 281474976710654,
  "fee_rate_per_vb": 3,
  "funding_txid": "885f04881e6cdc214dbd32df69fd8a2a2d1fef037d83f4c9d4821a73916fedf1",
  "funding_tx_vout": 2,
  "closing_txid": null,
  "user_email": "",
  "user_registration_timestamp": "2024-03-04T06:26:24.003559Z"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant