Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reock calculation to treat multipolygon districts individually #10

Closed
mxndrwgrdnr opened this issue Aug 11, 2017 · 1 comment
Closed

Comments

@mxndrwgrdnr
Copy link
Member

The reock code currently merges all points of a multipolygon (i.e. a group of islands or a district that includes an island) and finds the area of the convex hull for all points at once. This greatly exaggerates the area of the circumscribing circle, which should instead be the summation of the areas of the convex hulls of the individual polygons included in the multipolygon.

@r-barnes
Copy link
Collaborator

r-barnes commented Oct 15, 2017

The cpp branch, which is now on master, does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants