Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker style selector for GeoCarousel section #7109

Open
1 of 6 tasks
tdipisa opened this issue Jul 15, 2021 · 2 comments
Open
1 of 6 tasks

Marker style selector for GeoCarousel section #7109

tdipisa opened this issue Jul 15, 2021 · 2 comments

Comments

@tdipisa
Copy link
Member

tdipisa commented Jul 15, 2021

Description

Following the first implementation of the GeoCarousel section for for GeoStory (#6993), it is required to include the ability to customize the marker style through the UI.

  1. This is what is expected to customize the marker style for all markers (currently possible only via localConfig):

2021_07_15_16_39_38_.png

  1. This is what is expected to customize the style for a single carousel item:

Immagine.png

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

Point 1 only acts on markers not already customized via 2.

@dsuren1
Copy link
Contributor

dsuren1 commented Jul 27, 2021

Hi @tdipisa
Kindly clarify these,

  1. Do we have to support marker type symbol, if so we cannot display icon text that is essential to associate the marker with carousel item
    2021-07-27 12_43_57-MapStore HomePage
  2. Now that we are required to display icon text on the marker, we can hide the Icon field in the styler component ?
    68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3563396361383964363630376236373933633636656333352f30666134346561392d373731662d346265392d626431632d363764393362656136346637

@tdipisa
Copy link
Member Author

tdipisa commented Jul 27, 2021

  1. Do we have to support marker type symbol, if so we cannot display icon text that is essential to associate the marker with carousel item

Not strictly needed for GeoCarousel, the Type field can be hidden in this case

  1. Now that we are required to display icon text on the marker, we can hide the Icon field in the styler component ?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants