Fix #10734 Fix print tms layers with 4326 #10738
Open
+112
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsuren1
requested changes
Jan 8, 2025
There was a problem hiding this comment.
@MV88 as discussed earlier, I'm highlighting the issues that I observed with TMS & print tool
- With the TMS layer, the layers are not always included in the output. While the spec appears fine, the resulting output sometimes misses the layer. This issue occurs with both 3857 and 4326 projections. Perhaps it would provide some insight into why TMS layers were skipped when the projection was set to something other than the default 3857
- In certain cases, the layer is not previewed or displayed correctly in the print tool. This issue occurs when changing the CRS or opening the print tool with EPSG:4326, among other scenarios
- Using the OSM provider for TMS, the layer prints correctly when the CRS is 3857 but fails to print when it is set to 4326
Testing
I have used this map to test
Catalog services used
https://gs-stable.geo-solutions.it/geoserver/gwc/service/tms/1.0.0 (Layer: States of US)
https://public.sig.rennesmetropole.fr/geowebcache/service/tms/1.0.0 (Layer: Cadastre Rennes Métropole)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10734
What is the new behavior?
it prints also tms layers in 4326
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information