Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking Assistance with GEOS-Chem Sea Salt Mode Implementation Issue #2652

Open
ChenBHXMU opened this issue Dec 18, 2024 · 1 comment
Open
Assignees
Labels
category: Question Further information is requested topic: Convection and Mixing Related to cloud convection and PBL mixing

Comments

@ChenBHXMU
Copy link

Your name

Baihua Chen

Your affiliation

Xiamen University

Please provide a clear and concise description of your question or discussion topic.

Dear @yantosca ,

I hope this letter finds you well.

Currently, sea salt only includes SALC and SALA. I am researching how to add two mode for sea salt. However, I have encountered the following problem. While working in GCClassic/src/GEOS-Chem/GeosCore/convection_mod.F90, I encountered an issue where I traced it back to QC being NaN. I have modified the parameter TINYNUM to 1e-4_fp, but the problem persists. The version of GEOS-Chem is 14.4.3.

I understand that code modification is not your responsibility, but since I am unable to quickly grasp the architecture of this project, I am struggling to resolve this issue. I hope my work can contribute to the advancement of GEOS-Chem. Thank you for your assistance.

Best regards,
Baihua Chen
微信截图_20241218165810
微信截图_20241218171719

@ChenBHXMU ChenBHXMU added the category: Question Further information is requested label Dec 18, 2024
@yantosca yantosca added the topic: Convection and Mixing Related to cloud convection and PBL mixing label Dec 18, 2024
@yantosca yantosca self-assigned this Dec 18, 2024
@yantosca
Copy link
Contributor

Thanks for writnig @ChenBHXMU. TINYNUM should not be set to a value as high as 1e-4. It is meant to prevent underflow when very small values are encountered.

One suggestion: If you have introduced new variables into convection_mod.F90 (or anywhere, really), make sure to initialize them to zero before they are used. When you build GEOS-Chem with -DCMAKE_RELEASE_TYPE=Debug it will set uninitialized values to NaN to make it easier to find them. I wonder if this is what is happening here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Question Further information is requested topic: Convection and Mixing Related to cloud convection and PBL mixing
Projects
None yet
Development

No branches or pull requests

2 participants